Announcement

**Wayne Diamond** · 22 Apr 2001, 11:43 PM

Whats wrong? Whatever youve changed in it is wrong - the original works fine!
Im a bit tied up at the moment but I'll have a look at it in the next hour or two, but can you tell me first please what you want to do that is different to the original?

Cheers,
Wayne

[This message has been edited by Wayne Diamond (edited April 23, 2001).]

**Mike Trader** · 23 Apr 2001, 01:32 AM

Well it would not compile as is. The orginal did not use the MSGBOX or standard APIs. It also used STDIN which I have never seen and will not compile. I added a call to the Windows OpenDialog so that you can point to the file you want to CRC easily.

TO test it I made the CheckCRC a stand alone app that can also use the OpenDialog to point to the file to be checked.

Everything works but the check fails

Whenever you get a chance - no hurry.

------------------
Kind Regards
Mike

**Wayne Diamond** · 23 Apr 2001, 02:26 AM

Mike, the sample is for PB/CC not PB/DLL ... i highly recommend buying PB/CC, it is money well spent.
To convert it to PB/DLL, just replace STDOUT with MSGBOX, and replace STDIN LINE with anything that accepts input...
STDIN/OUT just works like this:

Code:

FUNCTION PBMAIN() AS LONG
 STDOUT "Enter your name: ";
 STDIN LINE YourName
 STDOUT "Hello there " & YourName
END FUNCTION

Im regretably busy at the moment and dont have time to port it to PB/DLL, but if you post your email address I can email you the compiled version of makecrc.exe if you want

Best regards,
Wayne

------------------

**Mike Trader** · 23 Apr 2001, 10:04 AM

Hi Wayne,

Oh thats it I see.

Well I allready ported it. MakeCRC works fine as does CheckCRC. but the result of MakeCRC is not whats expected. The result of MakeCRC is whats expected.

I think if you take a couple of minutes to compile the code above it should be obvious to a guru like you I suspect that there is just some small problem or oversight. I dont think you will be getting into anything heavy

I dont really want to post my e-mail adress here cos all this stuff goes in the archive for millenia! but if there were some other way to exchange addresses I would be happy to do that.

------------------
Kind Regards
Mike

**Mike Trader** · 23 Apr 2001, 12:42 PM

OK I think I found the problem.

MakeCRC is not adding the 8Byte checksum like its supposed to:
OPEN TargetFile FOR BINARY ACCESS WRITE AS #94
PUT #94, FileLength + 1, xHEX ' not working
CLOSE #94

so the GET in CheckCRC comes back with zero:
OPEN TargetFile FOR BINARY ACCESS READ AS #91
GET #91, FileLength - 7, xHEX ' why -7 by the way?

Other than that, the checksum appears to be calculated and encoded fine

Anyone got any ideas?

------------------
Kind Regards
Mike

**Wayne Diamond** · 23 Apr 2001, 01:07 PM

Mike,

Wednesday is a public holiday here in Australia and New Zealand (ANZAC Day) so Ill have a look at it then, but looking at your last question:

Code:

MakeCRC is not adding the 8Byte checksum like its supposed to:
OPEN TargetFile FOR BINARY ACCESS WRITE AS #94
PUT #94, FileLength + 1, xHEX ' not working
CLOSE #94

Add some debugging msgboxes in there...:

Code:

OPEN TargetFile FOR BINARY ACCESS WRITE AS #94
 IF ERR THEN MSGBOX "Error opening the file for binary write access"
 MSGBOX "FileLength=" & STR$(FileLength)
 PUT #94, FileLength + 1, xHEX ' not working
 MSGBOX "xHEX=" & xHEX
CLOSE #94

See what FileLength and XHex are, one of those values is probably not correct

------------------

**Mike Trader** · 25 Apr 2001, 10:38 AM

ANZAC day! wassat??

I have spent a while sticking MSGBOX dialogs everywhere. xHex is zero, file length is correct. I think xHex is zero cos the CRC (which appears to be correctly calculated) is not actually appended to the file with MakeCRC.

I have verified every step of Make CRC, bur the CRC is not getting written with:

OPEN TargetFile FOR BINARY ACCESS WRITE AS #94
PUT #94, FileLength + 1, xHEX ' not working
CLOSE #94

------------------
Kind Regards
Mike

**Wayne Diamond** · 25 Apr 2001, 11:05 AM

ANZAC Day (Australia & New Zealand Army Corps) is a public holiday where we remember and pay tribute to those that gave their lives answering the call to war to fight for peace in WW1, WW2, Vietnam, Korea, etc, and most recently East Timor. A very proud day for all Aussies & Kiwis. <tops up Lance's drink - cheers >
I'll have another look at the PB/DLL port of this as soon as I sober up enough to put code together - having problems putting sentences together at the moment so I'll wait a while

Cheers,
Wayne

------------------

**Mike Trader** · 25 Apr 2001, 12:46 PM

hehehe

I have created an account @ http://www.whalemail.com/
to send you the debug versions with msgboxs inserted etc to save you some time.
l = pbdll
p = waynescrc32
(All lower case)
pls read the message

Happy ANZAC day!

------------------
Kind Regards
Mike

**Wayne Diamond** · 25 Apr 2001, 02:08 PM

Ok, im back. I still cant put a sentence together, but funny enough I can still somehow get bugs out of code.
All you need to do is replace your makecrc.bas's PBMain function with this one:

Code:

FUNCTION PBMAIN() AS LONG
LOCAL TargetFile AS STRING, BUFFER AS STRING, xHEX AS STRING * 8
LOCAL CRC AS LONG, FileLength AS LONG, I AS LONG
    IF COMMAND$ = "" THEN
        TargetFile = OpenSaveDialog("Exe to append checksum to", "", "C:\PBDLL60\", "exe", "exe", 0)
        IF TargetFile = "" THEN EXIT FUNCTION
    ELSE
        TargetFile = COMMAND$
    END IF
'If you want to compress your exe, do it here before tagging the CRC checksum on the end:
'FileLength = SHELL("c:\aspack\aspack.exe " & TargetFile,1)
'SLEEP(3000)
FileLength = FileSize(TargetFile)
Open TargetFile For Binary Access Read As #94
 BUFFER = String$(FileLength, 0)
 Get #94, 1, BUFFER
 CRC = Crc32(StrPtr(BUFFER), Len(BUFFER), -1)
 CRC = CRC - 4096
 XHEX = Hex$(CRC)
Close #94
Open TargetFile For Binary Access Write Lock Read As #94
 Put #94, FileLength + 1, XHEX
 MSGBOX "Checksum=" & Hex$(CRC) & ", Size=" & Str$(Len(BUFFER)) & " bytes, First2=" & Left$(BUFFER, 2) & " (should be MZ)"
Close #94
END FUNCTION

Cheers,
Wayne

------------------

**Mike Trader** · 25 Apr 2001, 02:53 PM

OK I tried this. It seems the same as mine. Either way it does not seem to append the checksum. The file size should be 1 byte bigger right?
So If run the Makr CRC again the file size should have changed.

Either way when i run Check CRC it should show me a larger file too and xHex should not be zero. it is.
Am i missing something fundamental here? Os or some other prob (i use 98SE)

Also, Did you get the files from Whalemail OK?

------------------
Kind Regards
Mike

**Wayne Diamond** · 26 Apr 2001, 12:12 AM

Yep I used whalemail to download it before modifying, and it worked fine then. All I had to do was copy the PBMain function below into makecrc and it worked fine then...
PS. If you dont have one already, get yourself a good hex editor like HexWorkshop32

------------------

**Mike Trader** · 26 Apr 2001, 10:05 AM

Wayne,

What am I missing here. I does not work on my end

could you e-mail me privatly, I think we have taken up enough band width here

------------------
Kind Regards
Mike

Announcement

Attn: Wayne - CRC code problem

Attn: Wayne - CRC code problem

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment